feat(io): Implement native LocalFsStorage#2094
Merged
blackmwk merged 1 commit intoapache:mainfrom Feb 4, 2026
Merged
Conversation
CTTY
force-pushed
the
ctty/local-storage
branch
from
50664ba to
0c3e5f0
Compare
CTTY
commented
Feb 3, 2026
| /// - `/path/to/file` -> `/path/to/file` | ||
| /// ``` | ||
| #[derive(Debug, Clone, Default, Serialize, Deserialize)] | ||
| pub struct LocalFsStorage; |
Collaborator
Author
There was a problem hiding this comment.
We can add a new module io/storage and traits and implementations there. Opendal implementations can later be moved to a new crate iceberg-storage.
I'll create a different PR to refactor it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR depends on #2080
What changes are included in this PR?
LocalFsStorage, this can be used for testing simple casesAre these changes tested?
Added some uts