Skip to content

Core, ORC: surface struct-level null counts for content stats #17844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bujjibabukatta wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −1
Open

Core, ORC: surface struct-level null counts for content stats #17844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ac0944
Core, ORC: surface struct-level null counts for content stats
bujjibabukatta Aug 27, 2026
451b150
fix: remove extra blank line to satisfy spotless formatting
bujjibabukatta Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion core/src/main/java/org/apache/iceberg/StatsUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,23 @@ private static Types.NestedField upperBoundField(Type type, int baseId) {

@VisibleForTesting
static Types.StructType fieldStatsStruct(Type type, int baseId, MetricsModes.MetricsMode mode) {
if (null == mode || mode == MetricsModes.None.get() || type.isNestedType() || baseId < 0) {
if (null == mode || mode == MetricsModes.None.get() || baseId < 0) {
return null;
}

if (type.isStructType()) {
return Types.StructType.of(
optional(
baseId + VALUE_COUNT_OFFSET,
"value_count",
Types.LongType.get(),
"Number of values (including null)"),
optional(
baseId + NULL_VALUE_COUNT_OFFSET,
"null_value_count",
Types.LongType.get(),
"Number of null values"));
} else if (type.isNestedType()) {
return null;
}

Expand Down
1 change: 1 addition & 0 deletions orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ public Set<Integer> record(
.filter(Optional::isPresent)
.map(Optional::get)
.forEach(result::add);
ORCSchemaUtil.icebergID(record).ifPresent(result::add);
return result.build();
}
}
Expand Down
Loading