Dell: Preserve known ECS input file lengths - #17870
Open
charliec05 wants to merge 1 commit into
Open
Conversation
Carry known lengths into ECS input files so scan planning avoids redundant object metadata requests. Generated-by: Codex
singhpk234
reviewed
Aug 29, 2026
singhpk234
left a comment
singhpk234
left a comment
Contributor
There was a problem hiding this comment.
The change in general LGTM
Added a feedback for test assertion
|
|
||
| InputFile inputFile = fileIO.newInputFile(location, 10L); | ||
|
|
||
| assertThat(inputFile.getLength()).as("File length should use the known value").isEqualTo(10L); |
Contributor
There was a problem hiding this comment.
how are we asserting no request is made ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This avoids redundant ECS HEAD requests when Iceberg already knows a data, delete, or manifest file size.
Closes #17054
Testing
./gradlew :iceberg-dell:testAI Disclosure