fix(bdd): make ./scripts/run-bdd-tests.sh actually support FEATURE flag#3384
fix(bdd): make ./scripts/run-bdd-tests.sh actually support FEATURE flag#3384chengxilo wants to merge 15 commits into
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3384 +/- ##
============================================
- Coverage 74.65% 74.61% -0.04%
Complexity 943 943
============================================
Files 1228 1228
Lines 120529 120529
Branches 97263 97292 +29
============================================
- Hits 89975 89928 -47
- Misses 27614 27623 +9
- Partials 2940 2978 +38
🚀 New features to boost your workflow:
|
hubcio
left a comment
There was a problem hiding this comment.
one thing to confirm rather than a code issue: this PR drops the go -race BDD task (bdd-go-race, the -race flag and GO_TEST_EXTRA_FLAGS plumbing). no dangling references remain and the CI matrix entry goes away cleanly, so the removal itself is clean. worth a conscious sign-off on losing the data-race signal though - -race instruments the go test binary's own goroutines regardless of whether the server is real or mocked, so the "only applies to unit tests with a mock server" rationale isn't quite right. note coverage-baseline.yml still runs go test -race against tests/tcp_test, so some race coverage survives there.
Sorry it was a huge mistake. Fixed. I removed the -race from the coverage tho, since it only only cause nagative impact and we don't need race detection for coverage report. |
7bf8c80 to
1fb4cd8
Compare
1fb4cd8 to
2e82506
Compare
|
/ready |

Which issue does this PR address?
Relates to #2148
Rationale
In master branch, the
./scripts/run/bdd-tests.shdoesn't support choosing a feature, while there is aFEATUREvaraible.While this script is mainly for BDD test in CI, when we implement the bdd test it is also very helpful to verify if the BDD test works. So I hope this can be improved so when I build new test scenario, it won't take me 10 minutes to build and run everything everytime I wanna test it.
What changed?
In master branch, the
./scripts/run/bdd-tests.shdoesn't support choosing a feature, while there is aFEATUREvaraible. I splitted the docker-compose file for each.feature. Now when run basic_messaging scenario we only need to build and run thedocker-compose.server.ymlwhich create a single server, while in leader_redirection scenario we usedocker-compose.server.ymlanddocker-compose.cluster.ymltogether. It should increase the speed to run therun-bdd-tests.shthe
cleanis also updated by claude, but I think it makes sense so I kept it. Now if we use./scripts/run/bdd-tests.sh clean, it should clean up everything that is possible to be booted but failed to be removed. I didn't actually use it tho.And one extra change which is technically not in the scope, I removed go-race test in bdd, as I realized that it was a mistake to provide -race test in BDD test. It is only applicable for unit test with mock server.Local Execution
AI Usage