feat(java): add reporting suite to java bench#3420
Open
slbotbm wants to merge 4 commits into
Open
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Contributor
Author
|
I still need to verify some more things, so I converted this to a draft for now. Preliminary results of running the two benches are as follows: Commands ran: taskset -c 0-3 ./target/debug/iggy-server --fresh --with-default-root-credentials
taskset -c 4-7 ./gradlew --no-daemon :iggy-bench:run --args="pp"Rust: taskset -c 0-3 ./target/debug/iggy-server --fresh --with-default-root-credentials
taskset -c 4-7 ./target/debug/iggy-bench --warmup-time 60s pp tcp output -o .Results:
Generated reports: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3420 +/- ##
============================================
+ Coverage 74.43% 74.60% +0.16%
Complexity 943 943
============================================
Files 1245 1229 -16
Lines 121293 121022 -271
Branches 97599 97573 -26
============================================
Hits 90285 90285
+ Misses 28054 27783 -271
Partials 2954 2954
🚀 New features to boost your workflow:
|
2596ca3 to
8cf0ad1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #
Relates to #
Rationale
The java bench was missing a reporting suite, which meant no metrics collection was happening.
What changed?
Local Execution
AI Usage
If AI tools were used, please answer: