fix(ci): repair and harden pre-commit hooks and CI checks#3426
Open
hubcio wants to merge 2 commits into
Open
Conversation
Several pre-commit hooks were broken, unsafe, or masking drift: - helmfmt never worked: a bare `helmfmt` entry made v0.5.0 read template paths as chart paths. Pass the chart dir with --check, matching test-helm.sh. - typos -w silently corrupted hidden-file false positives, now whitelisted in .typos.toml (SerDe, Paket, the [Pp]ublish glob). - add missing trailing newlines to 12 SVGs, 4 LICENSE copies and web/.env that predated the hook. - relock stale bdd/examples uv.lock and add a python-lockfiles CI job so Dependabot per-dir relocks can no longer drift unseen. - quote $GITHUB_STEP_SUMMARY redirects (shellcheck SC2086). - rename sync-rust-version.sh to sync-rustc-version.sh and sync-python-version.sh to sync-python-interpreter-version.sh. - scope the license-headers duplicate scan to changed files (pass_filenames), cutting the hook from ~3.8s to ~0.1s.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3426 +/- ##
============================================
- Coverage 74.43% 74.42% -0.02%
Complexity 943 943
============================================
Files 1245 1245
Lines 121293 121293
Branches 97599 97626 +27
============================================
- Hits 90285 90272 -13
+ Misses 28054 28030 -24
- Partials 2954 2991 +37
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several pre-commit hooks were broken, unsafe, or masking drift:
helmfmtentry made v0.5.0 readtemplate paths as chart paths. Pass the chart dir with --check,
matching test-helm.sh.
whitelisted in .typos.toml (SerDe, Paket, the [Pp]ublish glob).
web/.env that predated the hook.
job so Dependabot per-dir relocks can no longer drift unseen.
sync-python-version.sh to sync-python-interpreter-version.sh.
(pass_filenames), cutting the hook from ~3.8s to ~0.1s.