Oak-12060: Regression Test for Elastic Inference Query#2790
Open
ChlineSaurus wants to merge 2 commits intoapache:OAK-12060from
Open
Oak-12060: Regression Test for Elastic Inference Query#2790ChlineSaurus wants to merge 2 commits intoapache:OAK-12060from
ChlineSaurus wants to merge 2 commits intoapache:OAK-12060from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, we don't have a test to ensure that the elastic queries constructed by Oak using the InferenceConfig don't have any regressions regarding the exact query sent to Elastic.
Issue: https://issues.apache.org/jira/browse/OAK-12060
Note: I am not very happy with this type of exact JSON payload testing, since most changes to the related code will require changes to this test. However, this level of regression testing was requested. If anyone has any ideas for improvements, I'd be happy to hear them.
New from: #2733