Skip to content

KAFKA-20379: ducker-ak has no option to skip the gradlew systemTestLibs build step#22034

Open
see-quick wants to merge 3 commits intoapache:trunkfrom
see-quick:KAFKA-20379
Open

KAFKA-20379: ducker-ak has no option to skip the gradlew systemTestLibs build step#22034
see-quick wants to merge 3 commits intoapache:trunkfrom
see-quick:KAFKA-20379

Conversation

@see-quick
Copy link
Copy Markdown
Contributor

This PR adds an option to skip the gradle build while running system tests.

Why

Add --skip-build support to ducker-ak test. Currently when someone wants to skip the build it (e.g., it is already builded in the CI) it cannot be skip because:

( (test -f ./gradlew || gradle) && ./gradlew systemTestLibs ) || die "ducker_test: Failed to build system test libraries, please check the error log."
is always called in the ducker_test method in the script.

Important

Additionally, run_tests.sh has a redundant REBUILD block (i.e.,:

if [ "$REBUILD" == "t" ]; then
./gradlew clean systemTestLibs
if [ "$KAFKA_MODE" == "native" ]; then
./gradlew clean releaseTarGz
fi
fi

and think is a dead code because ducker-ak test always rebuilds anyway (no matter what you set) here:

${SCRIPT_DIR}/ducker-ak test ${TC_PATHS} ${_DUCKTAPE_OPTIONS} || die "ducker-ak test failed"

Tested

  1. SKIP_BUILD=true ./tests/docker/ducker-ak test ./tests/kafkatest/tests/core/produce_bench_test.py => build is skipped
  2. ./tests/docker/ducker-ak test ./tests/kafkatest/tests/core/produce_bench_test.py => build is NOT skipped
  3. ./tests/docker/ducker-ak test --skip-build ./tests/kafkatest/tests/core/produce_bench_test.py => build is skipped
  4. SKIP_BUILD=true ./tests/docker/run_tests.sh => build is skipped
  5. ./tests/docker/run_tests.sh => build is NOT skipped
  6. ... (more)

Again as previous --memory option, --skip-build option has same priority (i.e., CLI > ENV > default option).

…bs build step

Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@github-actions github-actions bot added triage PRs from the community tests Test fixes (including flaky tests) small Small PRs labels Apr 13, 2026
Comment on lines -43 to -49
if [ "$REBUILD" == "t" ]; then
./gradlew clean systemTestLibs
if [ "$KAFKA_MODE" == "native" ]; then
./gradlew clean releaseTarGz
fi
fi

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check please this one (so I might miss something ...), but I think it is not needed as I think described this in the PR description.

@github-actions github-actions bot removed the triage PRs from the community label Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant