KAFKA-20379: ducker-ak has no option to skip the gradlew systemTestLibs build step#22034
Open
see-quick wants to merge 3 commits intoapache:trunkfrom
Open
KAFKA-20379: ducker-ak has no option to skip the gradlew systemTestLibs build step#22034see-quick wants to merge 3 commits intoapache:trunkfrom
see-quick wants to merge 3 commits intoapache:trunkfrom
Conversation
see-quick
commented
Apr 13, 2026
Comment on lines
-43
to
-49
| if [ "$REBUILD" == "t" ]; then | ||
| ./gradlew clean systemTestLibs | ||
| if [ "$KAFKA_MODE" == "native" ]; then | ||
| ./gradlew clean releaseTarGz | ||
| fi | ||
| fi | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Double-check please this one (so I might miss something ...), but I think it is not needed as I think described this in the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to skip the gradle build while running system tests.
Why
Add --skip-build support to ducker-ak test. Currently when someone wants to skip the build it (e.g., it is already builded in the CI) it cannot be skip because:
kafka/tests/docker/ducker-ak
Line 607 in acd37fc
ducker_testmethod in the script.Important
Additionally, run_tests.sh has a redundant REBUILD block (i.e.,:
kafka/tests/docker/run_tests.sh
Lines 43 to 48 in acd37fc
and think is a dead code because ducker-ak test always rebuilds anyway (no matter what you set) here:
kafka/tests/docker/run_tests.sh
Line 56 in acd37fc
Tested
Again as previous
--memoryoption,--skip-buildoption has same priority (i.e., CLI > ENV > default option).