KAFKA-20450 : Fix : Allowlist based SafeObjectInputStream#22056
Open
subbudvk wants to merge 1 commit intoapache:trunkfrom
Open
KAFKA-20450 : Fix : Allowlist based SafeObjectInputStream#22056subbudvk wants to merge 1 commit intoapache:trunkfrom
subbudvk wants to merge 1 commit intoapache:trunkfrom
Conversation
subbudvk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current SafeObjectInputStream uses a denylist based approach - having a fixed denylist to be validated against for deserialization. This is a bad security practise and has also been advised so in the original PR.
Making this as a allowlist instead and allowing safe BASE_TYPES which are required by current caller (org.apache.kafka.connect.storage.FileOffsetBackingStore)
Also providing a
SafeObjectInputStream(InputStream in, Set<String> allowedClasses)so if any consumer require any specific allowedClasses they can pass in here.