MINOR: Use maybeSetDslStoreFormatHeaders helper in more streams test classes#22057
Merged
chia7712 merged 3 commits intoapache:trunkfrom Apr 16, 2026
Merged
Conversation
github-actions
bot
added
triage
fix compile error
m1a2st
force-pushed
the
MINOR-maybeSetDslStoreFormatHeaders
branch
from
d462abf to
c4f503f
Compare
chia7712
reviewed
Apr 15, 2026
| if (withHeaders) { | ||
| streamsConfiguration.put(StreamsConfig.DSL_STORE_FORMAT_CONFIG, StreamsConfig.DSL_STORE_FORMAT_HEADERS); | ||
| } | ||
| IntegrationTestUtils.maybeSetDslStoreFormatHeaders(streamsConfiguration, withHeaders); |
Member
There was a problem hiding this comment.
Could we use StreamsTestUtils.maybeSetDslStoreFormatHeaders and then remove IntegrationTestUtils.maybeSetDslStoreFormatHeaders?
chia7712
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion:
#21820 (comment)
Reviewers: Chia-Ping Tsai chia7712@gmail.com