Fix writeHeader computation in RollingRandomAccessFileManager #4008
+78
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by gradle/develocity-actions |
vy
added
appenders:Rolling
Member
|
@NeatGuyCoding, the report and the fix look legitimate, thanks. Would you mind providing also a changelog entry and a test, please? I'd appreciate it if you can keep the test as minimal as possible. |
…llingRandomAccessFileManager
Contributor
Author
|
@vy done |
vy
requested changes
Dec 29, 2025
src/changelog/.2.x.x/fix_RollingRandomAccessFileManager_writeHeader.xml
Outdated
Show resolved
Hide resolved
...main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java
Show resolved
Hide resolved
.../java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManagerTest.java
Outdated
Show resolved
Hide resolved
…eader.xml Co-authored-by: Volkan Yazıcı <[email protected]>
…r/rolling/RollingRandomAccessFileManager.java Co-authored-by: Volkan Yazıcı <[email protected]>
NeatGuyCoding
force-pushed
the
hotfix-wrong-check
branch
from
6b45294 to
a46a03f
Compare
vy
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix writeHeader computation in RollingRandomAccessFileManager
The writeHeader boolean was computed after creating the RandomAccessFile, which creates the file if it doesn't exist. This made file.exists() always return true, causing incorrect header write decisions.
This change captures the file's pre-existing state before opening the RandomAccessFile by:
When fileName is null, fileExistedBefore remains false as expected.