Skip to content

Remove unreachable null check from BuildClasspathMojo #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilx wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Remove unreachable null check from BuildClasspathMojo #1666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/maven/plugins/dependency/fromDependencies/BuildClasspathMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ protected void doExecute() throws MojoExecutionException {

Set<Artifact> artifacts = getResolvedDependencies(true);

@elharo elharo Aug 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this method return null? what's it's contract? and if it can return null, should it be changed to return an empty set instead?

@wilx wilx Aug 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in the current Maven, I think. But I did not study all the versions.

@elharo elharo Aug 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the method marked nullable or non-nullable?

@wilx wilx Aug 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not marked.

@elharo elharo Aug 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an issue here. If the method doesn;t return null, it doesn't return null.

@wilx wilx Aug 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the check and reworded the commit.


if (artifacts == null || artifacts.isEmpty()) {
if (artifacts.isEmpty()) {
getLog().info("No dependencies found.");
}

Expand Down
Loading