Skip to content

[MDEP-870] Overwrite copied artifact POMs - #1669

Open
wilx wants to merge 1 commit into
apache:masterfrom
wilx:issue-1370-copy-pom-overwrite
Open

[MDEP-870] Overwrite copied artifact POMs#1669
wilx wants to merge 1 commit into
apache:masterfrom
wilx:issue-1370-copy-pom-overwrite

Conversation

@wilx

@wilx wilx commented Aug 2, 2026

Copy link
Copy Markdown

Summary

When dependency:copy-dependencies copies an artifact, overwrite its associated POM as well. This prevents version-stripped output from containing a JAR from one version and a pre-existing POM from another version.

Artifacts skipped by the configured overwrite policy retain the existing MDEP-164 behavior: their POM is copied only when it is missing.

Root cause

Copied and skipped artifacts shared the same copyPoms path, which unconditionally ignored an existing destination POM. As a result, an artifact selected for replacement could overwrite the versionless JAR while leaving its old versionless POM untouched.

Fixes #1370

Verification

  • The new regression test failed before the production change with expected: <new pom> but was: <old pom>.
  • Maven 3: mvn verify — 412 tests, 0 failures/errors, 1 skipped.
  • Maven 4 with JDK 21: mvn verify — 412 tests, 0 failures/errors, 1 skipped.
  • Focused Invoker build: mvn -DskipTests -Prun-its -Dinvoker.test=copy-dependencies verify — 1 passed.
  • Exact Commons Lang 3.12.0 to 3.14.0 reproducer: the resulting versionless JAR and POM checksums both match 3.14.0.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

When dependency:copy-dependencies copies an artifact, also overwrite its associated POM so version-stripped output cannot mix versions. Preserve copy-only-if-missing behavior for artifacts skipped by the overwrite policy.

Fixes apache#1370
@wilx
wilx marked this pull request as ready for review August 2, 2026 10:18
@elharo elharo added the bug Something isn't working label Aug 2, 2026
@wilx

wilx commented Aug 2, 2026

Copy link
Copy Markdown
Author
Suppressed: org.eclipse.aether.transfer.ArtifactTransferException: Could not transfer artifact org.ow2.asm:asm-util:pom:9.9 from/to central (https://repo.maven.apache.org/maven2): HTTP connect timed out

Some sort of infrastructure issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MDEP-870] artifact pom not overwritten

2 participants