[MDEP-870] Overwrite copied artifact POMs - #1669
Open
wilx wants to merge 1 commit into
Open
Conversation
When dependency:copy-dependencies copies an artifact, also overwrite its associated POM so version-stripped output cannot mix versions. Preserve copy-only-if-missing behavior for artifacts skipped by the overwrite policy. Fixes apache#1370
wilx
marked this pull request as ready for review
August 2, 2026 10:18
Author
Some sort of infrastructure issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
dependency:copy-dependenciescopies an artifact, overwrite its associated POM as well. This prevents version-stripped output from containing a JAR from one version and a pre-existing POM from another version.Artifacts skipped by the configured overwrite policy retain the existing MDEP-164 behavior: their POM is copied only when it is missing.
Root cause
Copied and skipped artifacts shared the same
copyPomspath, which unconditionally ignored an existing destination POM. As a result, an artifact selected for replacement could overwrite the versionless JAR while leaving its old versionless POM untouched.Fixes #1370
Verification
expected: <new pom> but was: <old pom>.mvn verify— 412 tests, 0 failures/errors, 1 skipped.mvn verify— 412 tests, 0 failures/errors, 1 skipped.mvn -DskipTests -Prun-its -Dinvoker.test=copy-dependencies verify— 1 passed.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.