[MDEP-927] Make dependency:tree excludes prune subtrees - #1671
Open
wilx wants to merge 1 commit into
Open
Conversation
wilx
marked this pull request as ready for review
August 2, 2026 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependency:treeprune a dependency matchingexcludestogether with its complete subtreeRoot cause
The existing implementation combined
includesandexcludesinto one node filter and applied it throughFilteringDependencyNodeVisitor. A rejected node was omitted from the serialized output, but its children were still traversed. When includes were also present, the ancestor-or-self pass could restore paths through nodes that had matched an exclude pattern.This change introduces a pruning visitor. A rejected node returns
falsefromvisit, preventing traversal of its children, while its matchingendVisitreturnstrueso traversal continues with the node's next sibling. The visitor remembers the acceptance decision made at the start of the visit so the delegate receives balancedvisit/endVisitcallbacks without evaluating the filter twice.Semantics and compatibility
This intentionally changes the output-filtering semantics of
dependency:tree:excludesis a structural pruning operation. A matching node and every node below it are absent from the serialized tree.includesis a positive filter over the tree that remains after pruning. It selects matching dependencies and retains the ancestor paths needed to reach them.As discussed in #1334, the current parameter names do not describe these distinct roles especially well. Names such as
filterfor the path-preserving positive selection andexclusionsfor subtree pruning would communicate the behavior more clearly. This PR retains the establishedincludesandexcludesnames for CLI and plugin-configuration compatibility. Introducing aliases, deprecating the existing names, or renaming them should be considered separately as an API migration.Validation
mvn spotless:applymvn verify— 412 tests passed, 1 skippedmvn -Prun-its verify— 99 integration-test projects passedmvn verify— 412 tests passed, 1 skippedmvn -Prun-its verify— 98 integration-test projects passed, 1 skipped due to its Maven-version condition-Dverbose=true: excludingorg.glassfish.jaxb:jaxb-runtimealso removesjaxb-core,txw2, andistack-commons-runtimeFixes #1427
Fixes #1334
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.