testing/ostest: add hrtimer API functional tests #3248
+240
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangchdo
force-pushed
the
add_hrtimer_tests
branch
2 times, most recently
from
80d315e to
cc4ee26
Compare
cederom
requested review from
acassis,
linguini1,
michallenc and
xiaoxiang781216
cederom
previously approved these changes
Dec 15, 2025
Contributor
There was a problem hiding this comment.
Thank you @wangchdo :-)
This PR should be merged after apache/nuttx#17489.
simbit18
previously approved these changes
Dec 15, 2025
wangchdo
force-pushed
the
add_hrtimer_tests
branch
from
cc4ee26 to
fd72386
Compare
Contributor
Author
|
tests updated according to updated in apache/nuttx#17489 |
simbit18
previously approved these changes
Dec 16, 2025
cederom
previously approved these changes
Dec 16, 2025
linguini1
previously approved these changes
Dec 16, 2025
wangchdo
force-pushed
the
add_hrtimer_tests
branch
from
fd72386 to
f2f9eac
Compare
Contributor
Author
|
@anchao @cederom @xiaoxiang781216 @linguini1 @simbit18 HRTimer tests have been updated according to @xiaoxiang781216's comments. The improvements include:
The ostest has passed on real hardware (a2g-tc397-5v-tft) for two consecutive runs. |
Add functional tests for the newly added hrtimer APIs, including hrtimer_init(), hrtimer_start(), and hrtimer_cancel(). Signed-off-by: Chengdong Wang <[email protected]>
wangchdo
force-pushed
the
add_hrtimer_tests
branch
from
f2f9eac to
56e2ed7
Compare
anchao
approved these changes
Dec 17, 2025
simbit18
approved these changes
Dec 17, 2025
cederom
approved these changes
Dec 17, 2025
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @wangchdo for the great work and @xiaoxiang781216 for valuable remarks! :-)
linguini1
approved these changes
Dec 17, 2025
| HRTIMER_TEST(NSEC_PER_500MS > diff - NSEC_MARGIN, true); | ||
| } | ||
|
|
||
| test->previous = test->now; |
Contributor
There was a problem hiding this comment.
change now to local variable
|
|
||
| /* Stop the test after 15 expirations */ | ||
|
|
||
| if (test->count >= 15) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (test->count >= 15) | |
| if (test->count >= 15) |
acassis
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add functional tests for the newly added hrtimer APIs,
including hrtimer_init(), hrtimer_start(), and hrtimer_cancel().
Impact
This PR depends on apache/nuttx#17489
Testing
ostest passed on a2g-tc397-5v-tft with hrtimer enalbed