sim/posix: Add APPLE to a build target for sim's configuration using CMake.#18883
Open
toku-mac wants to merge 1 commit into
Open
sim/posix: Add APPLE to a build target for sim's configuration using CMake.#18883toku-mac wants to merge 1 commit into
toku-mac wants to merge 1 commit into
Conversation
Member
|
@no1wudi Could you help to review the PR thanks :-) |
Member
|
@toku-mac Could you check CMakeLists.txt thanks :-) |
Author
|
Sorry, I fixed in commit 118d09c. |
Member
|
@toku-mac Remember to add "Signed-off-by" thanks :-) |
…CMake. * Adjust macOS coverage linker configuration settings. * Resolve linker errors caused by the absence of `-lgcov`. * Fix an issue where `macho_call_saved_init_funcs()` on macOS could improperly reference `g_saved_init_funcs`. * Eliminate the Rust/Tokio `clock_gettime()` panic that occurred when running `hello_rust_cargo` on the NuttX sim on macOS. * Add support for treating Darwin's `CLOCK_MONOTONIC=6` and `CLOCK_UPTIME_RAW=8` as NuttX's monotonic clock in `sched/clock/clock_gettime.c` (limited to sim/macOS environments). Signed-off-by: Shoji Tokunaga <toku@mac.com>
118d09c to
e14a952
Compare
Author
|
I squashed at commit e14a952 :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hello_rust_cargoCMake build configuration.gcc, its actual implementation isclang.About
macho_call_saved_init_funcs()Issuesave_and_replace_init_funcs()does not appear at the head of__mod_init_func. For example, consider this sequence:__mod_init_funcentries in the order they appear,constructor Ahas already executed beforesave_and_replace_init_funcs()is called.elsebranch until it findssave_and_replace_init_funcs(), where it executesg_saved_init_funcs[i - 1] = *fp;.i == 0, soi - 1becomes out-of-bounds when interpreted without sign, or-1even as anint, resulting in an invalid write tog_saved_init_funcs[-1].macho_call_saved_init_funcs()side.Impact
Testing
I confirm that changes are verified on local setup and works as intended:
See the apps PR #3482 .
PR verification Self-Check