Skip to content

Improve exception handling in ControllerLeaderLocator #17366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akanksha-kedia wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −6
Open

Improve exception handling in ControllerLeaderLocator #17366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,14 +206,41 @@ private Pair<String, Integer> getHelixClusterLeader() {
* @param instanceId instance id without any prefix, e.g. localhost_9000
*/
private Pair<String, Integer> convertToHostAndPortPair(String instanceId) {
// TODO: improve the exception handling.
if (instanceId == null) {
if (instanceId == null || instanceId.trim().isEmpty()) {
LOGGER.warn("Instance ID is null or empty");
return null;
}

try {
int index = instanceId.lastIndexOf('_');
if (index <= 0 || index >= instanceId.length() - 1) {
LOGGER.error("Invalid instance ID format: {}. Expected format: hostname_port", instanceId);
return null;
}

String leaderHost = instanceId.substring(0, index);
String portStr = instanceId.substring(index + 1);

if (leaderHost.trim().isEmpty()) {
LOGGER.error("Empty hostname in instance ID: {}", instanceId);
return null;
}

int leaderPort = Integer.parseInt(portStr);
if (leaderPort <= 0 || leaderPort > 65535) {
LOGGER.error("Invalid port number {} in instance ID: {}. Port must be between 1 and 65535",
leaderPort, instanceId);
return null;
}

return Pair.of(leaderHost, leaderPort);
} catch (NumberFormatException e) {
LOGGER.error("Failed to parse port number from instance ID: {}. Error: {}", instanceId, e.getMessage());
return null;
} catch (Exception e) {
LOGGER.error("Unexpected error while parsing instance ID: {}. Error: {}", instanceId, e.getMessage());
return null;
}
int index = instanceId.lastIndexOf('_');
String leaderHost = instanceId.substring(0, index);
int leaderPort = Integer.parseInt(instanceId.substring(index + 1));
return Pair.of(leaderHost, leaderPort);
}

/**
Expand Down
Loading