Fix broker tag reconciliation on restart to prevent stale tags #17433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17433 +/- ##
============================================
+ Coverage 63.30% 63.31% +0.01%
+ Complexity 1474 1468 -6
============================================
Files 3155 3155
Lines 188119 188135 +16
Branches 28792 28795 +3
============================================
+ Hits 119088 119118 +30
+ Misses 59800 59782 -18
- Partials 9231 9235 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#17432
Problem
When a broker restarts (especially on a different pod/host with different intended tags), it connects to Helix with stale tags from the previous run. The original code only updated tags for brand new brokers (
if (instanceTags.isEmpty())), leaving restarted brokers with incorrect tags that can cause traffic misrouting.Proposal
Added a method that runs on every broker startup to compare configured tags with Helix tags and updates them if they differ. This ensures brokers always announce with the correct tags, regardless of restart scenarios.