Skip to content

fix(bacnet): Don't fail the build when the vendor id can't be downlaoded. #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hutcheb wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(bacnet): Don't fail the build when the vendor id can't be downlaoded. #2378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions protocols/bacnetip/src/main/script/getVendorIds.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ if (update) {
println "Successfully updated BACnet Vendor IDs.htm"
} catch (Exception e) {
println "Got an error updating BACnet Vendor IDs.htm. Intentionally not failing the build as we might just be offline: " + e.getMessage()
// If we can't update the vendor id file, it may be older and we run the risk of incorrectly updating the repo with an older version.
// The vendor id website also has a cloudfare check which depending on the location may fail the build.
return
}
} else {
println "Skipped updating BACnet Vendor IDs.htm as it's fresh enough"
Expand Down
Loading