Skip to content

Conversation

@coderzc
Copy link
Member

@coderzc coderzc commented Dec 11, 2025

Motivation

2025-12-05T11:02:37,446+0000 [ForkJoinPool.commonPool-worker-2] ERROR org.apache.pulsar.broker.service.persistent.PersistentTopic - [persistent://pe/lab/result_pb-partition-1] Failed to create subscription: rw-consumer-855-7985
java.util.concurrent.CompletionException: org.apache.pulsar.broker.service.BrokerServiceException$NotAllowedException: Durable subscription with the same name already exists.

Modifications

Change log level form ERROR to Warn for NotAllowedException

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions
Copy link

@coderzc Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Dec 11, 2025
@Technoboy- Technoboy- added this to the 4.2.0 milestone Dec 15, 2025
Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add a test?

…ersistent/PersistentTopic.java

Co-authored-by: Lari Hotari <[email protected]>
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.45%. Comparing base (270120c) to head (4938e22).
⚠️ Report is 39 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #25064      +/-   ##
============================================
- Coverage     74.48%   74.45%   -0.04%     
+ Complexity    34186    34051     -135     
============================================
  Files          1921     1899      -22     
  Lines        150376   149711     -665     
  Branches      17469    17403      -66     
============================================
- Hits         112005   111462     -543     
+ Misses        29499    29372     -127     
- Partials       8872     8877       +5     
Flag Coverage Δ
inttests 26.35% <0.00%> (+<0.01%) ⬆️
systests 22.98% <0.00%> (+0.06%) ⬆️
unittests 73.99% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sar/broker/service/persistent/PersistentTopic.java 80.33% <100.00%> (+0.29%) ⬆️

... and 137 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants