-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][broker] Enhance logging for subscription creation failures due to NotAllowedException #25064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…due to NotAllowedException
|
@coderzc Please add the following content to your PR description and select a checkbox: |
Technoboy-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to add a test?
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
…ersistent/PersistentTopic.java Co-authored-by: Lari Hotari <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25064 +/- ##
============================================
- Coverage 74.48% 74.45% -0.04%
+ Complexity 34186 34051 -135
============================================
Files 1921 1899 -22
Lines 150376 149711 -665
Branches 17469 17403 -66
============================================
- Hits 112005 111462 -543
+ Misses 29499 29372 -127
- Partials 8872 8877 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Motivation
Modifications
Change log level form ERROR to Warn for NotAllowedException
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: