RANGER-5619: Keyadmin user unable to perform test connection for cm_k…#1024
Merged
Conversation
dhavalshah9131
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ms service
What changes were proposed in this pull request?
Added explicit role check in ServiceREST.validateConfig():
ROLE_SYS_ADMIN --> allowed for all services
ROLE_KEY_ADMIN --> allowed for KMS services only
All other roles --> FORBIDDEN
Initial fix caused a regression where KeyAdmin users were unable to test connection for cm_kms service. Fixed by allowing ROLE_KEY_ADMIN access for KMS service types only, verified via service definition implementation class name.
How was this patch tested?
added a new test