RANGER-5742: Inconsistent handling of service config fields by name v… - #1152
Open
vyommani wants to merge 1 commit into
Open
RANGER-5742: Inconsistent handling of service config fields by name v…#1152vyommani wants to merge 1 commit into
vyommani wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Service config masking (read) and encryption (write) previously only matched the literal key "password". Service-defs can declare other config items with type="password" under different names (e.g. NiFi's nifi.ssl.keystorePassword /truststorePassword) - those were left unmasked/unencrypted.
This change treats any config item as a secret if its key is "password" OR the service-def declares it with type="password", applied consistently across RangerServiceService (read/view) and ServiceDBStore (create/update). updateService now preserves the correct per-key value on the hidden-sentinel case instead of a single shared variable. Shared classification logic lives in one place (ServiceDBStore) to avoid drift.
How was this patch tested?
Added/updated unit tests in TestRangerServiceService and TestServiceDBStore covering masking, encryption, and per-key update behavior for service-def-declared secret keys.