Skip to content

[ISSUE #10442] Optimize message properties encode/decode to reduce allocation #10444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wang-jiahua wants to merge 1 commit into
base: develop
Choose a base branch
from
+522 −32
Open

[ISSUE #10442] Optimize message properties encode/decode to reduce allocation #10444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions common/src/main/java/org/apache/rocketmq/common/message/MessageConst.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@
*/
package org.apache.rocketmq.common.message;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;

public class MessageConst {
public static final String PROPERTY_KEYS = "KEYS";
Expand Down Expand Up @@ -102,6 +106,8 @@ public class MessageConst {

public static final HashSet<String> STRING_HASH_SET = new HashSet<>(64);

static final String[][] STRING_INTERN_BY_LEN;

public static final String PROPERTY_TIMER_ENQUEUE_MS = "TIMER_ENQUEUE_MS";
public static final String PROPERTY_TIMER_DEQUEUE_MS = "TIMER_DEQUEUE_MS";
public static final String PROPERTY_TIMER_ROLL_TIMES = "TIMER_ROLL_TIMES";
Expand Down Expand Up @@ -173,5 +179,20 @@ public class MessageConst {
STRING_HASH_SET.add(PROPERTY_CRC32);
STRING_HASH_SET.add(PROPERTY_PRIORITY);
STRING_HASH_SET.add(PROPERTY_LITE_TOPIC);
int maxLen = 0;
for (String key : STRING_HASH_SET) {
if (key.length() > maxLen) {
maxLen = key.length();
}
}
String[][] byLen = new String[maxLen + 1][];
Map<Integer, List<String>> bucketBuilder = new HashMap<>();
for (String key : STRING_HASH_SET) {
bucketBuilder.computeIfAbsent(key.length(), k -> new ArrayList<>()).add(key);
}
for (Map.Entry<Integer, List<String>> e : bucketBuilder.entrySet()) {
byLen[e.getKey()] = e.getValue().toArray(new String[0]);
}
STRING_INTERN_BY_LEN = byLen;
}
}
Loading
Loading