[ISSUE #10494] Fix flaky HATest.testSemiSyncReplica#10495
Open
RongtongJin wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10495 +/- ##
=============================================
- Coverage 48.08% 48.05% -0.03%
- Complexity 13326 13332 +6
=============================================
Files 1377 1377
Lines 100644 100707 +63
Branches 12995 13010 +15
=============================================
+ Hits 48393 48394 +1
- Misses 46329 46368 +39
- Partials 5922 5945 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HATestsemi-sync message writes.TRANSFERand the master connection ack offset covers the slave max physical offset.Root Cause
HATestpreviously waited only for the slave-side HA client to enterTRANSFER. That state can be reached before the master-sideHAConnectionreceives the slave's initial offset report, leavingslaveAckOffsetat-1. The first semi-sync write can race that initial report and returnFLUSH_SLAVE_TIMEOUTinstead ofPUT_OKon slower CI machines.Impact
This stabilizes
HATest.testSemiSyncReplicawithout changing production HA behavior.Fixes #10494
Validation
Full
HATestresult:Tests run: 4, Failures: 0, Errors: 0, Skipped: 1.Stress check:
Result: 100 consecutive
HATest#testSemiSyncReplicaruns passed.