Skip to content

Conversation

@wu-sheng
Copy link
Member

Summary

  • OAL: Add missing cpm function documentation, improve filter operators formatting with categorized list, clarify downsampling/TimeBucket behavior
  • MAL: Fix typos (valueNotEqual, tagNotMatch, combinates, fourse), fix wrong region in binary operator example, add missing Layer parameter to endpoint function signature
  • LAL: Fix endpoint description (was copy-pasted from instance), fix extractors typo to extractor, clarify rpm rate limit comments, remove grok (TODO) section
  • CLAUDE.md: Add tips for AI assistants about markdown rendering and relative paths in documentation

Test plan

  • Review rendered markdown on documentation website
  • Verify code examples are syntactically correct

🤖 Generated with Claude Code

- OAL: Add cpm function docs, improve filter operators formatting,
  clarify downsampling/TimeBucket behavior
- MAL: Fix typos (valueNotEqual, tagNotMatch, combinates, fourse),
  fix wrong region in example, add missing Layer param to endpoint
- LAL: Fix endpoint description, fix extractor typo, clarify rpm
  rate limit comments, remove grok TODO
- CLAUDE.md: Add tips for markdown rendering and relative paths
@wu-sheng wu-sheng requested review from Copilot and wankai123 January 19, 2026 02:29
@wu-sheng wu-sheng added this to the 10.4.0 milestone Jan 19, 2026
@wu-sheng wu-sheng added documentation Provide documents related issue or pull request only. backend OAP backend related. labels Jan 19, 2026
@wu-sheng wu-sheng merged commit 22534f1 into master Jan 19, 2026
22 checks passed
@wu-sheng wu-sheng deleted the fix/docs-oal-mal-lal-improvements branch January 19, 2026 02:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR polishes the documentation for OAL (Observability Analysis Language), MAL (Meter Analysis Language), and LAL (Log Analysis Language) by fixing typos, improving formatting, adding missing documentation, and clarifying behavior.

Changes:

  • Fixed multiple typos across documentation files (e.g., "valueNotEqual" description, "tagNotMatch" description, "combinates" → "combines")
  • Improved filter operators documentation in OAL with categorized list format
  • Added missing cpm function documentation and clarified downsampling behavior in OAL
  • Added Layer parameter to endpoint function signature in MAL
  • Fixed incorrect region reference in MAL binary operator example
  • Corrected endpoint extractor description in LAL and removed outdated grok (TODO) section
  • Added helpful tips for AI assistants in CLAUDE.md

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
docs/en/concepts-and-designs/oal.md Fixed typo, reorganized filter operators with categories, added cpm function docs, clarified downsampling behavior, updated examples to use percentile2
docs/en/concepts-and-designs/mal.md Fixed typos in filter descriptions, corrected region in example, added missing Layer parameter to endpoint function, fixed "combinates" typo
docs/en/concepts-and-designs/lal.md Fixed endpoint extractor description, corrected grammar, clarified rpm rate limit comments, removed outdated grok section, fixed "extractors" typo
CLAUDE.md Added documentation tips about markdown rendering and relative path handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Comparison: `==`, `!=`, `>`, `<`, `>=`, `<=`
- Collection: `in [...]` (e.g., `name in ("Endpoint1", "Endpoint2")`)
- String matching: `like %...`, `like ...%`, `like %...%` (e.g., `name like "serv%"`)
- Tag matching: `contain`, `not contain` (e.g., `tags contain "http.method:GET"`)
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected at the end of this line. Consider removing it for consistency with coding standards.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. documentation Provide documents related issue or pull request only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants