-
Notifications
You must be signed in to change notification settings - Fork 29.2k
[SPARK-56956][SDP] Introduce AutoCDC Flow Dataclasses #56042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
AnishMahto
wants to merge
11
commits into
apache:master
from
AnishMahto:SPARK-56956-introduce-flow-data-classes
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3a267cb
Introduce AutoCdcFlow and AutoCdcMergeFlow
AnishMahto 418d18a
add AutoCdcFlow -> AutoCdcMergeFlow resolution
AnishMahto 17717b3
disallow multiflow for AutoCDC
AnishMahto b4c4c0e
linting
AnishMahto 3ae939d
reorder error conditions alphabetically
AnishMahto 1839cb5
fix compile error
AnishMahto c321c42
PR feedback
AnishMahto 3751a6c
PR feedback
AnishMahto 8ef25c0
scaladoc
AnishMahto 9e34887
drop duplicate word in doc
AnishMahto 5e76481
missing import
AnishMahto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UntypedFlowresolution usesfuncResult.dataFrame.get.isStreamingto chooseStreamingFlowvsCompleteFlow, butAutoCdcFlowalways becomesAutoCdcMergeFlowregardless of whether the source is streaming.That means an
AutoCdcFlowwith a batch source can still resolve successfully when the destination is a non-streaming table (e.g. materialized view), becausevalidateFlowStreamingnessonly rejects streaming sources for MVs—not batch sources for AutoCDC specifically.Since this PR documents that AutoCDC is streaming-only (
once = false, class-level comments), consider enforcingdf.isStreaminghere (or invalidateFlowStreamingnesswith an AutoCDC-specific check), e.g.:Happy to defer to the execution PR if you prefer, but worth tracking so we don't rely on destination-type checks alone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is a good question, but we don't actually need to do anything here because:
spark.read_stream(source))Eventually we will support AutoCDC once flows which would indeed be batch flows, but that's not supported today -
once = falsealways by construction.As a middle ground though I'll also introduce a test demonstrating that AutoCDC flows cannot write to MVs in either the flow execution or flow registration PR.