[MINOR][BUILD] Give run-in-container a shebang - #58352
Closed
nchammas wants to merge 1 commit into
Closed
Conversation
nchammas
marked this pull request as draft
August 27, 2026 18:56
Contributor
Author
|
@HyukjinKwon / @panbingkun - It seems this script has been broken at least since #57581 and maybe for longer. To get it to work locally, I needed to:
Since this doesn't run on CI, I think no one noticed the breakage. I would prefer to remove the I won't open a PR for that, however, unless you agree. I know that some people strongly prefer to use Docker for everything. I am not one of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Give
run-in-containera shebang and update its one invocation accordingly.Why are the changes needed?
It's not common (or IMO appropriate) for a shell script to have neither an extension nor a shebang. IDEs don't know how to highlight the code, and invoking the script becomes more complicated than necessary.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
TODO:
Was this patch authored or co-authored using generative AI tooling?
No.