[SPARK-59067][CORE] Fix Download to be a button aligned with the other buttons - #58369
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-59067][CORE] Fix Download to be a button aligned with the other buttons#58369dongjoon-hyun wants to merge 1 commit into
Download to be a button aligned with the other buttons#58369dongjoon-hyun wants to merge 1 commit into
Conversation
Member
Author
|
Could you review this PR, @yaooqinn ? |
peter-toth
approved these changes
Aug 28, 2026
Member
Author
|
Thank you, @peter-toth ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 28, 2026
…her buttons ### What changes were proposed in this pull request? This PR makes the `Download` control of the SQL execution page a real button, aligned with the neighboring `Copy Plan` and `Copy Link` buttons. - Replace the `<label>`-wrapped `<a class="downloadbutton">` with a `<button>` using the same classes as the other buttons, and add a download icon and a `title` tooltip. - Change `Copy Link` from `ms-1` to `ms-2` so that all three buttons are evenly spaced. - Add an `aria-label` to the format `<select>`, which lost its accessible name with the removed `<label>`. ### Why are the changes needed? `Download` was a plain text link next to two Bootstrap buttons, so it was shorter than them, and `margin-right: 10px` from `a.downloadbutton` made the gaps between the three controls uneven after Apache Spark 4.2.0 added the other buttons. - #54886 **BEFORE (Apache Spark 4.2.0)** <img width="425" height="268" alt="Screenshot 2026-08-27 at 18 26 46" src="https://github.com/user-attachments/assets/1d6f4c23-ca43-46d5-8e77-4181f2c4185a" /> **AFTER** <img width="452" height="269" alt="Screenshot 2026-08-27 at 18 25 38" src="https://github.com/user-attachments/assets/798cabcd-6ef0-49f4-a4ae-b5d6f14ca3ca" /> ### Does this PR introduce _any_ user-facing change? Yes, but it is a UI-only change in the unreleased master branch. `Download` is now a button with an icon, and its functionality is unchanged. ### How was this patch tested? Manually checked the SQL execution page in a browser. No test was added because this only changes the Web UI markup. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5 Closes #58369 from dongjoon-hyun/SPARK-59067. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit bdda145) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 28, 2026
…her buttons ### What changes were proposed in this pull request? This PR makes the `Download` control of the SQL execution page a real button, aligned with the neighboring `Copy Plan` and `Copy Link` buttons. - Replace the `<label>`-wrapped `<a class="downloadbutton">` with a `<button>` using the same classes as the other buttons, and add a download icon and a `title` tooltip. - Change `Copy Link` from `ms-1` to `ms-2` so that all three buttons are evenly spaced. - Add an `aria-label` to the format `<select>`, which lost its accessible name with the removed `<label>`. ### Why are the changes needed? `Download` was a plain text link next to two Bootstrap buttons, so it was shorter than them, and `margin-right: 10px` from `a.downloadbutton` made the gaps between the three controls uneven after Apache Spark 4.2.0 added the other buttons. - #54886 **BEFORE (Apache Spark 4.2.0)** <img width="425" height="268" alt="Screenshot 2026-08-27 at 18 26 46" src="https://github.com/user-attachments/assets/1d6f4c23-ca43-46d5-8e77-4181f2c4185a" /> **AFTER** <img width="452" height="269" alt="Screenshot 2026-08-27 at 18 25 38" src="https://github.com/user-attachments/assets/798cabcd-6ef0-49f4-a4ae-b5d6f14ca3ca" /> ### Does this PR introduce _any_ user-facing change? Yes, but it is a UI-only change in the unreleased master branch. `Download` is now a button with an icon, and its functionality is unchanged. ### How was this patch tested? Manually checked the SQL execution page in a browser. No test was added because this only changes the Web UI markup. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5 Closes #58369 from dongjoon-hyun/SPARK-59067. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit bdda145) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 28, 2026
…her buttons ### What changes were proposed in this pull request? This PR makes the `Download` control of the SQL execution page a real button, aligned with the neighboring `Copy Plan` and `Copy Link` buttons. - Replace the `<label>`-wrapped `<a class="downloadbutton">` with a `<button>` using the same classes as the other buttons, and add a download icon and a `title` tooltip. - Change `Copy Link` from `ms-1` to `ms-2` so that all three buttons are evenly spaced. - Add an `aria-label` to the format `<select>`, which lost its accessible name with the removed `<label>`. ### Why are the changes needed? `Download` was a plain text link next to two Bootstrap buttons, so it was shorter than them, and `margin-right: 10px` from `a.downloadbutton` made the gaps between the three controls uneven after Apache Spark 4.2.0 added the other buttons. - #54886 **BEFORE (Apache Spark 4.2.0)** <img width="425" height="268" alt="Screenshot 2026-08-27 at 18 26 46" src="https://github.com/user-attachments/assets/1d6f4c23-ca43-46d5-8e77-4181f2c4185a" /> **AFTER** <img width="452" height="269" alt="Screenshot 2026-08-27 at 18 25 38" src="https://github.com/user-attachments/assets/798cabcd-6ef0-49f4-a4ae-b5d6f14ca3ca" /> ### Does this PR introduce _any_ user-facing change? Yes, but it is a UI-only change in the unreleased master branch. `Download` is now a button with an icon, and its functionality is unchanged. ### How was this patch tested? Manually checked the SQL execution page in a browser. No test was added because this only changes the Web UI markup. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5 Closes #58369 from dongjoon-hyun/SPARK-59067. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit bdda145) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes the
Downloadcontrol of the SQL execution page a real button, aligned with the neighboringCopy PlanandCopy Linkbuttons.<label>-wrapped<a class="downloadbutton">with a<button>using the same classes as the other buttons, and add a download icon and atitletooltip.Copy Linkfromms-1toms-2so that all three buttons are evenly spaced.aria-labelto the format<select>, which lost its accessible name with the removed<label>.Why are the changes needed?
Downloadwas a plain text link next to two Bootstrap buttons, so it was shorter than them, andmargin-right: 10pxfroma.downloadbuttonmade the gaps between the three controls uneven after Apache Spark 4.2.0 added the other buttons.BEFORE (Apache Spark 4.2.0)
AFTER
Does this PR introduce any user-facing change?
Yes, but it is a UI-only change in the unreleased master branch.
Downloadis now a button with an icon, and its functionality is unchanged.How was this patch tested?
Manually checked the SQL execution page in a browser. No test was added because this only changes the Web UI markup.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5