Prefer run bin scripts with uv #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
commented
Nov 5, 2025
| THIS_DIR=$(/bin/dirname "`realpath $0`") | ||
| PARENT_DIR=$(/bin/dirname "$THIS_DIR") | ||
| THIS_DIR=$(dirname "`realpath $0`") | ||
| PARENT_DIR=$(dirname "$THIS_DIR") |
Member
Author
There was a problem hiding this comment.
On macOS, dirname locates at /usr/bin/dirname. Use dirname for compatibility.
tisonkun
commented
Nov 5, 2025
| @@ -1,4 +1,5 @@ | |||
| #!/bin/bash | |||
| #!/usr/bin/env bash | |||
Member
Author
There was a problem hiding this comment.
Use the same flavor like Python scripts to resolve commands.
tisonkun
commented
Nov 5, 2025
Member
Author
There was a problem hiding this comment.
Rename file to keep using kebab-style.
Member
There was a problem hiding this comment.
I imagined another script importing this to do more sophisticated loading of fake data. ... but we can cross that bridge if that ever happens.
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #60