Skip to content

fix(nativeFilters): Native filters not applied when ALERT_REPORT_TABS disabled#38558

Draft
alexandrusoare wants to merge 1 commit intomasterfrom
alexandrusoare/fix/native-filters-no-tabs
Draft

fix(nativeFilters): Native filters not applied when ALERT_REPORT_TABS disabled#38558
alexandrusoare wants to merge 1 commit intomasterfrom
alexandrusoare/fix/native-filters-no-tabs

Conversation

@alexandrusoare
Copy link
Contributor

SUMMARY

When ALERT_REPORTS_FILTER=True but ALERT_REPORT_TABS=False, native filters configured on dashboard reports were silently ignored during screenshot capture.

Root Cause: In get_dashboard_urls(), native filter params were only computed inside the ALERT_REPORT_TABS feature flag branch, so the else branch returned URLs without filters.

Fix: Moved the native filter computation outside the ALERT_REPORT_TABS conditional, gated by ALERT_REPORTS_FILTER instead. Now filters are applied to dashboard URLs regardless of whether the tabs feature is enabled

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant