fix(nativeFilters): Native filters not applied when ALERT_REPORT_TABS disabled#38558
Draft
alexandrusoare wants to merge 1 commit intomasterfrom
Draft
fix(nativeFilters): Native filters not applied when ALERT_REPORT_TABS disabled#38558alexandrusoare wants to merge 1 commit intomasterfrom
alexandrusoare wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
When
ALERT_REPORTS_FILTER=TruebutALERT_REPORT_TABS=False, native filters configured on dashboard reports were silently ignored during screenshot capture.Root Cause: In
get_dashboard_urls(), native filter params were only computed inside theALERT_REPORT_TABSfeature flag branch, so the else branch returned URLs without filters.Fix: Moved the native filter computation outside the
ALERT_REPORT_TABSconditional, gated byALERT_REPORTS_FILTERinstead. Now filters are applied to dashboard URLs regardless of whether the tabs feature is enabledBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION