fix(country-map): update Nepal from obsolete 14 zones to current 7 provinces - #43343
Open
1yuv wants to merge 3 commits into
Open
fix(country-map): update Nepal from obsolete 14 zones to current 7 provinces#433431yuv wants to merge 3 commits into
1yuv wants to merge 3 commits into
Conversation
Contributor
|
Bito Review Skipped - No Changes Detected |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43343 +/- ##
=======================================
Coverage 66.84% 66.84%
=======================================
Files 2876 2876
Lines 164069 164069
Branches 37866 37866
=======================================
Hits 109666 109666
Misses 52228 52228
Partials 2175 2175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Nepal's map used the pre-2015 14 zones with ISO codes that were removed from ISO 3166-2; replaced with the current 7 provinces (NP-P1 Koshi … NP-P7 Sudurpashchim). Source: geoBoundaries gbOpen NPL/ADM1 (CC BY 3.0 IGO, Nepal government data via data.humdata.org), following the existing Kenya pattern in the generator notebook. Notebook updated (alt_maps + simplify_factors + Nepal cell) so regeneration preserves the fix. Fixes #43342 .
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
Example with populated data:
TESTING INSTRUCTIONS
create a Country Map chart, select Nepal, use NP-P1…NP-P7 as the region column values. Check here for mapping of code and province.
ADDITIONAL INFORMATION