fix(ci): repair nightly pre-commit failures by sadpandajoe · Pull Request #43366 · apache/superset

sadpandajoe · 2026-08-20T16:54:49Z

SUMMARY

The nightly all-files pre-commit workflow fails on master for three independent deterministic reasons:

MyPy rejects the semantic-layer column_formats mapping because its inferred dict[str, str] type is invariant with the ExplorableData field's dict[str, str | None] type.
Oxfmt rewrites ColumnConfigControl/types.ts, leaving the scheduled formatter check dirty.
Ruff classifies superset_core as first-party after the semantic-layer package marker was added and requires an import-group separator in layer.py.

This change explicitly annotates the mapping with the public API value type and applies the repository-pinned formatter/linter output. The branch is merged through the investigated master baseline so the Ruff classification is exercised without rewriting branch history.

The two isolated Jest failures observed on adjacent master commits were unrelated flakes and are intentionally not patched here.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not applicable; CI-only type and formatting fixes.

TESTING INSTRUCTIONS

pre-commit run mypy --all-files — passed.
Oxfmt 0.64 check on the affected frontend files — passed.
Ruff 0.9.7 check on superset-core/src/superset_core/semantic_layers/layer.py and superset/semantic_layers/models.py — passed.
pre-commit run --all-files was executed before push. MyPy, Oxfmt, Oxlint, custom frontend rules, stylelint, and the other relevant hooks passed. The complete local run remained non-green because the worktree lacked Docs ESLint dependencies and built TypeScript package declarations, while the host Ruff/Pylint environment exposed unrelated repository-wide baseline/tool-version findings. PR CI is the authoritative full-environment verification.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2026-08-20T17:02:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.17%. Comparing base (7b145a5) to head (15c6aff).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #43366   +/-   ##
=======================================
  Coverage   79.16%   79.17%           
=======================================
  Files        2879     2879           
  Lines      165801   165819   +18     
  Branches    38325    38330    +5     
=======================================
+ Hits       131264   131290   +26     
+ Misses      32064    32056    -8     
  Partials     2473     2473

Flag	Coverage Δ
hive	`37.95% <0.00%> (ø)`
javascript	`74.60% <ø> (+0.01%)`	⬆️
mysql	`57.67% <0.00%> (ø)`
postgres	`57.71% <0.00%> (+<0.01%)`	⬆️
presto	`39.86% <0.00%> (ø)`
python	`83.75% <100.00%> (-0.01%)`	⬇️
sqlite	`57.40% <0.00%> (ø)`
unit	`73.97% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bito-code-review · 2026-08-25T19:36:28Z

Code Review Agent Run #949dd8

Actionable Suggestions - 0

Review Details

Files reviewed - 5 · Commit Range: f015871..f015871
- superset-frontend/src/explore/components/controls/ColumnConfigControl/types.ts
- superset-frontend/src/explore/components/controls/FixedOrMetricControl/FixedOrMetricControl.test.tsx
- superset-frontend/src/features/datasets/AddDataset/DatasetPanel/DatasetPanel.test.tsx
- superset-frontend/src/features/datasets/AddDataset/DatasetPanel/DatasetPanelWrapper.test.tsx
- superset/semantic_layers/models.py
Files skipped - 0
Tools
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers an incremental AI Review.
/review full - Manually triggers a full AI Review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

netlify · 2026-08-26T16:28:15Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`15c6aff`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6a90c752d2f7b00008a70a26
😎 Deploy Preview	https://deploy-preview-43366--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

bito-code-review · 2026-08-27T02:25:57Z

Code Review Agent Run #fbc8bd

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: 33d9bd4..33d9bd4
- superset-core/src/superset_core/semantic_layers/layer.py
- superset-frontend/src/explore/components/controls/ColumnConfigControl/types.ts
- superset/semantic_layers/models.py
Files skipped - 0
Tools
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers an incremental AI Review.
/review full - Manually triggers a full AI Review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

rusackas

LGTM, thanks for chasing down all three of those. Nice touch pinning the mypy annotation to the actual ExplorableData field type instead of just widening or ignoring it.

pull-request-size Bot added the size/M label Aug 20, 2026

sadpandajoe requested a review from rusackas August 20, 2026 17:14

sadpandajoe marked this pull request as ready for review August 20, 2026 17:14

dosubot Bot added change:backend Requires changing the backend change:frontend Requires changing the frontend labels Aug 20, 2026

sadpandajoe marked this pull request as draft August 20, 2026 17:27

sadpandajoe requested review from betodealmeida and removed request for rusackas August 20, 2026 17:32

sadpandajoe marked this pull request as ready for review August 25, 2026 16:30

sadpandajoe requested a review from rusackas August 25, 2026 16:30

pull-request-size Bot added size/XS and removed size/M labels Aug 26, 2026

sadpandajoe marked this pull request as draft August 26, 2026 16:36

sadpandajoe marked this pull request as ready for review August 26, 2026 16:36

sadpandajoe closed this Aug 26, 2026

sadpandajoe reopened this Aug 26, 2026

sadpandajoe marked this pull request as draft August 26, 2026 16:53

sadpandajoe marked this pull request as ready for review August 26, 2026 18:48

fix(ci): repair nightly pre-commit failures

33d9bd4

rusackas force-pushed the codex/ci-master-e7dccd4-20260820 branch from 3daa41f to 33d9bd4 Compare August 26, 2026 23:24

sadpandajoe mentioned this pull request Aug 27, 2026

fix(ci): repair scheduled pre-commit drift #43603

Merged

9 tasks

Merge branch 'master' into codex/ci-master-e7dccd4-20260820

15c6aff

rusackas approved these changes Aug 29, 2026

View reviewed changes

Navigation Menu

Uh oh!

fix(ci): repair nightly pre-commit failures - #43366

fix(ci): repair nightly pre-commit failures#43366
sadpandajoe wants to merge 2 commits into
masterfrom
codex/ci-master-e7dccd4-20260820

sadpandajoe commented Aug 20, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Aug 20, 2026 •

edited

Loading

Uh oh!

bito-code-review Bot commented Aug 25, 2026 •

edited

Loading

Code Review Agent Run #949dd8

Uh oh!

netlify Bot commented Aug 26, 2026 •

edited

Loading

Uh oh!

bito-code-review Bot commented Aug 27, 2026 •

edited

Loading

Code Review Agent Run #fbc8bd

Uh oh!

rusackas left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sadpandajoe commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codecov Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bito-code-review Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #949dd8

Uh oh!

netlify Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

bito-code-review Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #fbc8bd

Uh oh!

rusackas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sadpandajoe commented Aug 20, 2026 •

edited

Loading

codecov Bot commented Aug 20, 2026 •

edited

Loading

bito-code-review Bot commented Aug 25, 2026 •

edited

Loading

netlify Bot commented Aug 26, 2026 •

edited

Loading

bito-code-review Bot commented Aug 27, 2026 •

edited

Loading