feat(dashboard): add chart query inspector - #43376
Conversation
Code Review Agent Run #a1e87bActionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43376 +/- ##
=======================================
Coverage 66.84% 66.84%
=======================================
Files 2876 2876
Lines 164066 164102 +36
Branches 37863 37878 +15
=======================================
+ Hits 109666 109702 +36
Misses 52226 52226
Partials 2174 2174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Code Review Agent Run #f48370Actionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code Review Agent Run #eb65edActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
SUMMARY
Enhances the dashboard chart View query action into a permission-aware Query inspector, following the troubleshooting workflow popularized by Grafana's panel inspector.
The inspector keeps the existing generated SQL behavior and adds:
queriesResponseas copyable JSON;Raw response JSON is only available when the user can already explore the chart or use View as table. Users with only query-view permission retain access to generated SQL and aggregate stats.
Discussion: #43375
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not included because this development environment does not have a running Superset backend. The UI behavior is covered by focused React tests.
TESTING INSTRUCTIONS
Automated checks:
ViewQueryModal.test.tsx: 7 passedSliceHeaderControls.test.tsx: 46 passednpm run typepassed after building workspace declarationsADDITIONAL INFORMATION