Skip to content

[SYSTEMDS-3891] Wire OOC Materialized Stores - #2577

Merged
janniklinde merged 2 commits into
apache:mainfrom
janniklinde:ooc/planner-merge-20
Aug 4, 2026
Merged

[SYSTEMDS-3891] Wire OOC Materialized Stores#2577
janniklinde merged 2 commits into
apache:mainfrom
janniklinde:ooc/planner-merge-20

Conversation

@janniklinde

Copy link
Copy Markdown
Contributor

This patch wires the materialized stores as a replacement for CachingStream in the Tee instruction. Additionally, it patches an issue with packed logical tiles, that could have previously been removed while still being pinned.

@janniklinde
janniklinde force-pushed the ooc/planner-merge-20 branch from 193e7ba to 9adb704 Compare August 3, 2026 14:27
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.66008% with 97 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.42%. Comparing base (7a0e5ca) to head (3a7ef10).

Files with missing lines Patch % Lines
...runtime/ooc/store/MaterializedStoreStreamable.java 64.63% 46 Missing and 12 partials ⚠️
...sysds/runtime/ooc/cache/packed/OOCPackedCache.java 55.55% 13 Missing and 3 partials ⚠️
...ds/runtime/instructions/ooc/TeeOOCInstruction.java 41.17% 5 Missing and 5 partials ⚠️
...sysds/runtime/ooc/store/OOCStreamMaterializer.java 14.28% 5 Missing and 1 partial ⚠️
...untime/ooc/primitives/MaterializeOOCPrimitive.java 72.22% 2 Missing and 3 partials ⚠️
.../runtime/controlprogram/caching/CacheableData.java 0.00% 0 Missing and 1 partial ⚠️
.../sysds/runtime/instructions/ooc/OOCStreamable.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2577      +/-   ##
============================================
- Coverage     71.62%   71.42%   -0.20%     
+ Complexity    50459    50399      -60     
============================================
  Files          1628     1629       +1     
  Lines        195067   195285     +218     
  Branches      38042    38067      +25     
============================================
- Hits         139714   139483     -231     
- Misses        44420    44883     +463     
+ Partials      10933    10919      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janniklinde
janniklinde merged commit 759d5b6 into apache:main Aug 4, 2026
87 of 88 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in SystemDS PR Queue Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant