Skip to content

TIKA-4756#2889

Open
tballison wants to merge 2 commits into
mainfrom
TIKA-4756
Open

TIKA-4756#2889
tballison wants to merge 2 commits into
mainfrom
TIKA-4756

Conversation

@tballison

Copy link
Copy Markdown
Contributor

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika is successfully built and unit tests pass by running ./mvnw clean test
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR (TIKA-4756) improves PDF signature detection by distinguishing presence of AcroForm signature fields from presence of an actual applied signature, enabling correct reporting for PDFs that include unsigned /FT /Sig fields.

Changes:

  • Add new PDF metadata flag pdf:hasSignatureFields to indicate /FT /Sig fields exist even if unsigned.
  • Update PDFParser.extractSignatures() to set PDF.HAS_SIGNATURE_FIELDS based on PDDocument.getSignatureFields() and only set TikaCoreProperties.HAS_SIGNATURE when a non-null PDSignature is present.
  • Extend PDFParserTest with a new regression test for an unsigned signature field scenario and tighten expectations for the existing AcroForm signature-related test.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tika-parsers/.../PDFParserTest.java Adds assertions and a new test to verify unsigned signature fields are detected without reporting hasSignature.
tika-parsers/.../PDFParser.java Updates signature extraction to report signature-field presence separately from actual signature values.
tika-core/src/main/java/org/apache/tika/metadata/PDF.java Introduces PDF.HAS_SIGNATURE_FIELDS metadata property.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants