Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR (TIKA-4756) improves PDF signature detection by distinguishing presence of AcroForm signature fields from presence of an actual applied signature, enabling correct reporting for PDFs that include unsigned /FT /Sig fields.
Changes:
- Add new PDF metadata flag
pdf:hasSignatureFieldsto indicate/FT /Sigfields exist even if unsigned. - Update
PDFParser.extractSignatures()to setPDF.HAS_SIGNATURE_FIELDSbased onPDDocument.getSignatureFields()and only setTikaCoreProperties.HAS_SIGNATUREwhen a non-nullPDSignatureis present. - Extend
PDFParserTestwith a new regression test for an unsigned signature field scenario and tighten expectations for the existing AcroForm signature-related test.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tika-parsers/.../PDFParserTest.java |
Adds assertions and a new test to verify unsigned signature fields are detected without reporting hasSignature. |
tika-parsers/.../PDFParser.java |
Updates signature extraction to report signature-field presence separately from actual signature values. |
tika-core/src/main/java/org/apache/tika/metadata/PDF.java |
Introduces PDF.HAS_SIGNATURE_FIELDS metadata property. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)./mvnw clean testmainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!