-
Notifications
You must be signed in to change notification settings - Fork 93
Feat/c python timeseries metadata #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,641
−2
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c4a1238
c and python get_metadata interface wrapper
hongzhi-gao 9fc3e82
python c metadata interface
hongzhi-gao 135a2c0
spotless apply
hongzhi-gao a809120
fix DeviceTimeseriesMetadataEntry details
hongzhi-gao 6bfe1ef
replace DeviceID to TsDeviceDetails
hongzhi-gao e18a51b
fix c/python statistic
hongzhi-gao a392dd7
mvn spotless:apply
hongzhi-gao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typedef struct BaseStatistics {
TSDataType type;
int32_t row_count;
int64_t start_time;
int64_t end_time;
} BaseStatistic
typedef struct FloatStatistics {
BaseStatistic _base;
double min_float64;
double max_float64;
double first_float64;
double last_float64;
} FloatStatistic
May consider patterns like this?
Otherwise, the memory footprint of Statistics will be much higher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed