test(chart): make default image assertions package portable#8
Merged
weicao merged 1 commit intoJul 14, 2026
Merged
Conversation
Author
|
Focused review on exact head Independent checks:
This is a test-portability approval only. It is not runtime PASS. If merged into PR #7, the candidate SHA/package SHA must be re-pinned before fresh runtime evidence is counted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Packaging the chart with a release version changes
.Chart.Version. Three StatefulSet tests hardcoded the source checkout version0.0.1, so the exact release package from PR #7 produced 214 PASS / 3 FAIL even though explicit runtime image values rendered correctly.Change
Set an explicit synthetic
chart.version: 9.8.7-testfixture in the three tests that validate default image tags, and assert that tag. This locks the intended contract: the default image tag follows.Chart.Versionregardless of source checkout or package metadata.Production templates and values are unchanged.
Evidence
d7255ec022952ab13a874ff928d2e32e6cfb50e2helm unittest chart: 217/217 PASShelm package --version 0.35.1-b98b1ae5a-d7255ec0, extract, thenhelm unittest: 217/217 PASShelm lint chart: PASSgit diff --check: PASSThis child PR must be reviewed before merging into PR #7. It does not change or block the existing explicit b98 fresh-runtime gate.