Skip to content

ci(e2e): run the harness on Node 22, which pnpm 11 requires - #837

Merged
jarvis9443 merged 1 commit into
mainfrom
chore/node-22
Jul 29, 2026
Merged

ci(e2e): run the harness on Node 22, which pnpm 11 requires#837
jarvis9443 merged 1 commit into
mainfrom
chore/node-22

Conversation

@jarvis9443

Copy link
Copy Markdown
Contributor

#836 moved the e2e job to pnpm 11 but left actions/setup-node on Node 20. pnpm 11 requires Node 22.13 or newer — it imports node:sqlite for its store index — so that combination is only working by accident: this job never reaches the store code path, so the install succeeds. Any pnpm command that does touch the store (pnpm store path, a cache: pnpm step, a future harness change) fails with ERR_UNKNOWN_BUILTIN_MODULE.

That is not hypothetical — it is exactly how the same pnpm bump broke the control plane's dashboard and UI-image jobs, which do run pnpm store path via setup-node's cache: api7/AISIX-Cloud#1172.

GitHub is deprecating Node 20 on its runners anyway; the job logs already warn about it.

The e2e job installs with pnpm 11 but set up Node 20. pnpm 11 requires
Node 22.13 or newer — it imports `node:sqlite` for its store index — and
the job passes today only because it never reaches that code path. Any
pnpm command touching the store fails with ERR_UNKNOWN_BUILTIN_MODULE,
which is exactly how the same bump broke the control plane's dashboard
jobs (api7/AISIX-Cloud#1172).

GitHub is deprecating Node 20 on its runners as well, so this is where
the job was heading regardless.
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 44ed9486-c3be-45b5-bbc3-50d87243fe8c

📥 Commits

Reviewing files that changed from the base of the PR and between d6a3ecb and c9f8466.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Comment @coderabbitai help to get the list of available commands.

@jarvis9443
jarvis9443 merged commit c78f1a1 into main Jul 29, 2026
9 checks passed
@jarvis9443
jarvis9443 deleted the chore/node-22 branch July 29, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant