Skip to content

fix(openapi): Add missing response fields returned by the live API#2561

Merged
vdusek merged 9 commits into
masterfrom
fix/build-short-build-number
May 25, 2026
Merged

fix(openapi): Add missing response fields returned by the live API#2561
vdusek merged 9 commits into
masterfrom
fix/build-short-build-number

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented May 22, 2026

Align OpenAPI schemas with what the live Apify API actually returns, so the generated apify-client-python Pydantic models declare every documented field. Originally reported as apify-client-python#811 for buildNumber on BuildShort; broadened after running the Python integration suite with Pydantic extra='forbid' to surface the full gap across ~20 schemas (Actor, Build, KVS, Run, Schedule, Webhook, User plan/limits, store listings, …).

The build list endpoint returns buildNumber, but it was missing from the
BuildShort schema. As a result, generated clients (e.g. Pydantic models
in apify-client-python) treated it as an undeclared extra field, exposing
it only under the camelCase name and breaking the snake_case convention.
@vdusek vdusek requested a review from janbuchar as a code owner May 22, 2026 18:17
@vdusek vdusek added the adhoc Ad-hoc unplanned task added during the sprint. label May 22, 2026
@vdusek vdusek requested a review from fnesveda as a code owner May 22, 2026 18:17
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels May 22, 2026
@vdusek vdusek self-assigned this May 22, 2026
@github-actions github-actions Bot added this to the 141st sprint - Tooling team milestone May 22, 2026
@apify-service-account
Copy link
Copy Markdown
Contributor

apify-service-account commented May 22, 2026

🗑️ Preview for this PR was deleted.

@apify-service-account
Copy link
Copy Markdown
Contributor

Important

Action required@vdusek please coordinate this docs PR with the Python API client PR linked below.

Because this PR modifies the OpenAPI specification, the generated models in apify-client-python must be regenerated to stay in sync. This has already been done automatically:

A companion PR has been opened in apify-client-python with the regenerated models: apify/apify-client-python#821

  • Please make sure to review and merge both PRs together to keep the OpenAPI spec and API clients in sync.
  • You can ask for review and help from the Tooling team if needed.

Comment thread apify-api/openapi/components/schemas/actor-builds/BuildShort.yaml
…ests

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@apify-service-account
Copy link
Copy Markdown
Contributor

Important

Action required@vdusek please coordinate this docs PR with the Python API client PR linked below.

Because this PR modifies the OpenAPI specification, the generated models in apify-client-python must be regenerated to stay in sync. This has already been done automatically:

The companion apify-client-python PR has been updated with the latest spec changes: apify/apify-client-python#821

  • Please make sure to review and merge both PRs together to keep the OpenAPI spec and API clients in sync.
  • You can ask for review and help from the Tooling team if needed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vdusek vdusek changed the title fix(openapi): add buildNumber to BuildShort schema fix(openapi): align schemas with live API responses May 23, 2026
@apify-service-account
Copy link
Copy Markdown
Contributor

Important

Action required@vdusek please coordinate this docs PR with the Python API client PR linked below.

Because this PR modifies the OpenAPI specification, the generated models in apify-client-python must be regenerated to stay in sync. This has already been done automatically:

The companion apify-client-python PR has been updated with the latest spec changes: apify/apify-client-python#821

  • Please make sure to review and merge both PRs together to keep the OpenAPI spec and API clients in sync.
  • You can ask for review and help from the Tooling team if needed.

@vdusek vdusek marked this pull request as draft May 23, 2026 19:20
…s fields

CI integration tests failed because:
- the API returns sourceType=SOURCE_CODE which is not in VersionSourceType enum
- DatasetStats list responses omit storageBytes (only inflatedBytes/readCount/writeCount are returned)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@apify-service-account
Copy link
Copy Markdown
Contributor

Important

Action required@vdusek please coordinate this docs PR with the Python API client PR linked below.

Because this PR modifies the OpenAPI specification, the generated models in apify-client-python must be regenerated to stay in sync. This has already been done automatically:

The companion apify-client-python PR has been updated with the latest spec changes: apify/apify-client-python#821

  • Please make sure to review and merge both PRs together to keep the OpenAPI spec and API clients in sync.
  • You can ask for review and help from the Tooling team if needed.

…okSummary

- VersionSourceType: add SOURCE_CODE value the API actually returns (was producing literal_error in client validation)
- WebhookDispatch.webhook: extract inline object to a top-level WebhookDispatchWebhookSummary schema so codegen doesn't synthesize a Webhook1 name that collides with the Webhook schema

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@apify-service-account
Copy link
Copy Markdown
Contributor

Important

Action required@vdusek please coordinate this docs PR with the Python API client PR linked below.

Because this PR modifies the OpenAPI specification, the generated models in apify-client-python must be regenerated to stay in sync. This has already been done automatically:

The companion apify-client-python PR has been updated with the latest spec changes: apify/apify-client-python#821

  • Please make sure to review and merge both PRs together to keep the OpenAPI spec and API clients in sync.
  • You can ask for review and help from the Tooling team if needed.

@apify-service-account
Copy link
Copy Markdown
Contributor

Important

Action required@vdusek please coordinate this docs PR with the Python API client PR linked below.

Because this PR modifies the OpenAPI specification, the generated models in apify-client-python must be regenerated to stay in sync. This has already been done automatically:

The companion apify-client-python PR has been updated with the latest spec changes: apify/apify-client-python#821

  • Please make sure to review and merge both PRs together to keep the OpenAPI spec and API clients in sync.
  • You can ask for review and help from the Tooling team if needed.

@vdusek vdusek changed the title fix(openapi): align schemas with live API responses fix(openapi): Add missing response fields returned by the live API May 25, 2026
@vdusek vdusek marked this pull request as ready for review May 25, 2026 07:35
@apify-service-account
Copy link
Copy Markdown
Contributor

Important

Action required@vdusek please coordinate this docs PR with the Python API client PR linked below.

Because this PR modifies the OpenAPI specification, the generated models in apify-client-python must be regenerated to stay in sync. This has already been done automatically:

The companion apify-client-python PR has been updated with the latest spec changes: apify/apify-client-python#821

  • Please make sure to review and merge both PRs together to keep the OpenAPI spec and API clients in sync.
  • You can ask for review and help from the Tooling team if needed.

@vdusek
Copy link
Copy Markdown
Contributor Author

vdusek commented May 25, 2026

@fnesveda Could you please verify the version regexes (versionNumber, buildNumber, ActorDefinition.version)?

@apify-service-account
Copy link
Copy Markdown
Contributor

Important

Action required@vdusek please coordinate this docs PR with the Python API client PR linked below.

Because this PR modifies the OpenAPI specification, the generated models in apify-client-python must be regenerated to stay in sync. This has already been done automatically:

The companion apify-client-python PR has been updated with the latest spec changes: apify/apify-client-python#821

  • Please make sure to review and merge both PRs together to keep the OpenAPI spec and API clients in sync.
  • You can ask for review and help from the Tooling team if needed.

@vdusek vdusek requested a review from janbuchar May 25, 2026 08:02
Copy link
Copy Markdown
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version number always has to be three numbers, never two, otherwise looks good

Comment thread apify-api/openapi/components/schemas/actor-builds/Build.yaml Outdated
Comment thread apify-api/openapi/components/schemas/actor-builds/BuildShort.yaml Outdated
Comment thread apify-api/openapi/components/schemas/actor-runs/Run.yaml Outdated
Comment thread apify-api/openapi/components/schemas/actor-runs/RunShort.yaml Outdated
Comment thread apify-api/openapi/components/schemas/actors/TaggedBuildInfo.yaml Outdated
@apify-service-account
Copy link
Copy Markdown
Contributor

Important

Action required@vdusek please coordinate this docs PR with the Python API client PR linked below.

Because this PR modifies the OpenAPI specification, the generated models in apify-client-python must be regenerated to stay in sync. This has already been done automatically:

The companion apify-client-python PR has been updated with the latest spec changes: apify/apify-client-python#821

  • Please make sure to review and merge both PRs together to keep the OpenAPI spec and API clients in sync.
  • You can ask for review and help from the Tooling team if needed.

@vdusek vdusek requested a review from fnesveda May 25, 2026 11:28
@vdusek vdusek merged commit 93e6ee0 into master May 25, 2026
16 checks passed
@vdusek vdusek deleted the fix/build-short-build-number branch May 25, 2026 14:23
vdusek added a commit to apify/apify-client-python that referenced this pull request May 25, 2026
This PR updates the auto-generated Pydantic models and TypedDicts based
on OpenAPI specification changes in [apify-docs PR
#2561](apify/apify-docs#2561).

---------

Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants