ci: Gate manual release workflows on wait-for-checks#907
Merged
Conversation
Merge _check_code.yaml, _check_docs.yaml, _check_package.yaml, and _tests.yaml into a single _checks.yaml that exposes each check as a job. Reduces duplication across on_master.yaml and on_pull_request.yaml and gives every check the shared `Checks /` prefix. unit_tests, integration_tests, and e2e_tests carry `if: inputs.run_tests` so on_master.yaml can keep skipping tests for docs-only commits. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replace each release workflow's inline `code_checks` with a `wait-for-checks` step that verifies the `Checks` workflow already passed on the dispatch commit (it runs via `on_master.yaml` on every push). Adds the gate to the stable, beta, docs release, and docs versioning workflows that previously had none or rebuilt the code checks. Every caller that invokes a workflow requesting `checks: read` (reusable workflows are capped at the caller's permissions) explicitly grants it: doc_release in on_master.yaml, version_docs and doc_release in manual_release_stable.yaml, and doc_release_post_publish in manual_release_beta.yaml. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #907 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 48 48
Lines 2942 2942
=======================================
Hits 2561 2561
Misses 381 381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janbuchar
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the CI consolidation and
wait-for-checksadoption fromcrawlee-pythontoapify-sdk-python. See apify/crawlee-python#1913 for the original rationale and PR description; the follow-up permission fixes from #1914 and #1915 are baked in here.Two commits:
_check_code.yaml,_check_docs.yaml,_check_package.yaml, and_tests.yamlinto a single_checks.yaml. Every check now carries the sharedChecks /prefix.unit_tests,integration_tests, ande2e_testsare gated on arun_testsinput soon_master.yamlcan keep skipping tests for docs-only commits.code_checksstep inmanual_release_stable.yaml/manual_release_beta.yaml/manual_release_docs.yaml/manual_version_docs.yamlwith anapify/actions/wait-for-checks@v1.2.0step that verifies theChecksworkflow already passed on the dispatch commit (it runs viaon_master.yamlon every push). Every reusable-workflow caller that ends up requestingchecks: read(docs jobs inon_master.yaml,version_docs/doc_releaseinmanual_release_stable.yaml,doc_release_post_publishinmanual_release_beta.yaml) explicitly grants the permission, since reusable workflows are capped at the caller's permission set.