Skip to content

fix(templates): Pin playwright to base image version in uv Dockerfile template #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 4 commits into from
May 26, 2026
+11 −10
Merged

fix(templates): Pin playwright to base image version in uv Dockerfile template #1904

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
709d61a
fix: Pin playwright to base image version in `uv` Dockerfile template
vdusek May 19, 2026
7fbb85f
refactor: Simplify uv playwright pinning to single reinstall step
vdusek May 25, 2026
bd01ec1
use full option name in scripts
vdusek May 25, 2026
0549486
address feedback
vdusek May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions src/crawlee/project_template/{{cookiecutter.project_name}}/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,11 @@ RUN echo "Python version:" \
&& echo "All installed Python packages:" \
&& pip freeze
# % elif cookiecutter.package_manager == 'uv'
RUN pip install -U pip setuptools \
&& pip install 'uv<1'
COPY --from=ghcr.io/astral-sh/uv:0.11 /uv /uvx /bin/

# Snapshot the base image's playwright version before uv sync so we can pin to it later
# and stay aligned with the browser binaries baked into /pw-browsers.
RUN hash playwright 2>/dev/null && playwright --version | cut -d ' ' -f 2 > /tmp/.base-playwright-version || true

ENV UV_PROJECT_ENVIRONMENT="/usr/local"

Expand All @@ -51,15 +54,13 @@ COPY pyproject.toml uv.lock ./
RUN echo "Python version:" \
&& python --version \
&& echo "Installing dependencies:" \
# Check if playwright is already installed
&& PLAYWRIGHT_INSTALLED=$(pip freeze | grep -q playwright && echo "true" || echo "false") \
&& if [ "$PLAYWRIGHT_INSTALLED" = "true" ]; then \
echo "Playwright already installed, excluding from uv sync" \
&& uv sync --frozen --no-install-project --no-editable -q --no-dev --inexact --no-install-package playwright; \
else \
echo "Playwright not found, installing all dependencies" \
&& uv sync --frozen --no-install-project --no-editable -q --no-dev --inexact; \
&& uv sync --frozen --no-install-project --no-editable --quiet --no-dev --inexact \
&& PLAYWRIGHT_BASE_VERSION=$(cat /tmp/.base-playwright-version 2>/dev/null || echo "") \
&& if [ -n "$PLAYWRIGHT_BASE_VERSION" ]; then \
echo "Pinning playwright to $PLAYWRIGHT_BASE_VERSION to match the browser binaries shipped in the base image" \
&& uv pip install --reinstall --no-deps "playwright==$PLAYWRIGHT_BASE_VERSION"; \
fi \
&& rm -f /tmp/.base-playwright-version \
&& echo "All installed Python packages:" \
&& pip freeze
# % elif cookiecutter.package_manager == 'pip'
Expand Down
Loading