Skip to content

test: Bump goto timeout in flaky test_resource_management #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
May 26, 2026
+2 −1
Merged

test: Bump goto timeout in flaky test_resource_management #1916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/unit/browsers/test_browser_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ async def test_resource_management(server_url: URL) -> None:

async with BrowserPool([playwright_plugin]) as browser_pool:
page = await browser_pool.new_page()
await page.page.goto(str(server_url))
# Use a generous navigation timeout to avoid flakes on slow Windows CI runners.
await page.page.goto(str(server_url), timeout=60_000)
assert page.page.url == str(server_url)
assert '<html' in await page.page.content() # there is some HTML content
assert browser_pool.total_pages_count == 1
Expand Down
Loading