-
Notifications
You must be signed in to change notification settings - Fork 781
feat(dataset): add collect_all_keys option and keep CSV export columns aligned
#2079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
030c78e
fix(dataset): keep CSV columns aligned for items with different keys
anxkhn 6e60ba7
fix(dataset): include all CSV export columns
anxkhn bde4ba2
fix(dataset): bound CSV export memory usage
anxkhn 35ee524
fix(dataset): stream CSV exports by default
anxkhn 15e8783
fix(dataset): signal dropped CSV columns and validate writer options …
vdusek 94ba83e
test(dataset): decouple CSV writer option assertion from CPython wording
vdusek d090f55
fix(dataset): avoid CSV export crashes on non-string keys and mismatc…
vdusek ef2eb49
Merge remote-tracking branch 'origin/master' into fix/csv-export-colu…
vdusek 46da14f
fix(dataset): warn about export_data kwargs of the other format
vdusek a7f475d
fix(dataset): stop filtering export_data kwargs by format
vdusek 0384d3f
refactor(dataset): make collect_all_keys an explicit export parameter
vdusek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.