feat: Publish dual CJS and ESM builds#84
Closed
mykola-mokhnach wants to merge 2 commits into
Closed
Conversation
mykola-mokhnach
requested review from
KazuCocoa and
eglitise
and removed request for
eglitise
July 25, 2026 13:27
Several Date.now()-based assertions in test/asyncbox.spec.ts asserted against their exact theoretical floor/ceiling with zero slack, causing intermittent CI failures under timer jitter (e.g. https://github.com/appium/asyncbox/actions/runs/30159766440). Widen them to match the tolerance already used elsewhere in the same file. Also move test/cjs-interop.spec.cjs out of the standalone smoke/ directory and into test/, excluding it from the TypeScript project via tsconfig.json so it isn't type-checked or duplicated into both build outputs.
Contributor
|
This mixes up several unrelated changes, so I would prefer if the lint/format changes were moved to a separate PR. |
Contributor
Author
This is a small repo and the amount of changes is small. I expect splitting this PR would require more tokens than its creation |
Contributor
|
My point is that it's more complicated to review as a result. I'm not confident enough in CJS/ESM specifics to review them, but that's not the case for the lint/formatting changes. (also I don't think we should be optimising for token use if that results in PRs that combine multiple different changes, but perhaps that's just me) |
Contributor
Author
|
Closed in favour of #85 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details