Fix machine run ENOEXEC for amd64 machines on arm64 host#1847
Draft
iamvirul wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixes #1843.
MachinesService.boot()callsClientKernel.getDefaultKernel(for: .current)when no custom kernel path is configured. On Apple Silicon,.currentresolves to.linuxArm, so AMD64 machines boot with thedefault-arm64kernel binary instead ofdefault-amd64.The two are distinct binaries. The
default-amd64kernel is compiled with the Rosetta and binfmt_misc support required to run AMD64 userspace on ARM64 hosts. Without it, non-root exec processes fail withENOEXEC(errno=8) when attempting to run AMD64 binaries through the binfmt_misc handler.This is why the machine itself boots (PID 1 runs as root, unaffected) but
container machine run -n ubuntu unamefails (uses the host user uid, which is non-root).The custom kernel path branch in the same function already handled this correctly via
self.systemPlatform(from: state.snapshot.configuration.platform). The default kernel path branch was inconsistent with it.Testing
Reproduced with the steps in #1843 and confirmed
container machine run -n ubuntu uname -asucceeds after the fix.