commands: replace force-try with try in DNS create and delete#1849
Open
ArasanDev wants to merge 1 commit into
Open
commands: replace force-try with try in DNS create and delete#1849ArasanDev wants to merge 1 commit into
ArasanDev wants to merge 1 commit into
Conversation
Contributor
|
@ArasanDev Hi! You need to configure commit signing - we can't build without verified commits. https://github.com/apple/containerization/blob/main/CONTRIBUTING.md#pull-requests |
IPAddress("127.0.0.1") is called inside async throws functions, so the
force-try is unnecessary. Use try instead to comply with NeverUseForceTry
and allow the error to propagate naturally.
ArasanDev
force-pushed
the
fix/dns-force-try
branch
from
1c23845 to
2c59f6c
Compare
Author
|
Hi @jglogan — commit signing is now configured (SSH key registered on the ArasanDev account). The re-signed commit is |
Contributor
|
@ArasanDev - signed, but not verified. You probably need to make sure that the email on your ssh key matches a registered GH email for your account. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
IPAddress("127.0.0.1")is called insideasync throwsfunctions inDNSCreateandDNSDelete. The force-try (try!) is unnecessary — the surrounding function already propagates errors. This replaces both withtryto comply with theNeverUseForceTryrule enforced by swift-format.Testing
make testpasses (561 tests)