cctl: deprecate creds over http#788
Open
crosbymichael wants to merge 1 commit into
Open
Conversation
Signed-off-by: michael_crosby <michael_crosby@apple.com>
crosbymichael
force-pushed
the
http-cleartext
branch
from
e473dcb to
431b0d3
Compare
jglogan
reviewed
Jul 7, 2026
| var unpackPath: String? | ||
|
|
||
| @Flag(help: "Pull via plain text http") var http: Bool = false | ||
| @Flag(help: "(DEPRECATED) Pull via plain-text HTTP. Stored credentials will not be used; this flag will be removed in a future release.") |
Contributor
There was a problem hiding this comment.
Should this flag be deprecated? Or should it just ensure that credentials are not sent?
Suggested change
| @Flag(help: "(DEPRECATED) Pull via plain-text HTTP. Stored credentials will not be used; this flag will be removed in a future release.") | |
| @Flag(help: "Pull anonymously via plain-text HTTP") |
| @Option(help: "Platform string in the form 'os/arch/variant'. Example 'linux/arm64/v8', 'linux/amd64'") var platformString: String? | ||
|
|
||
| @Flag(help: "Push via plain text http") var http: Bool = false | ||
| @Flag(help: "(DEPRECATED) Push via plain-text HTTP. Stored credentials will not be used; this flag will be removed in a future release.") |
Contributor
There was a problem hiding this comment.
Same comment here.
Suggested change
| @Flag(help: "(DEPRECATED) Push via plain-text HTTP. Stored credentials will not be used; this flag will be removed in a future release.") | |
| @Flag(help: "Push anonymously via plain-text HTTP.") |
|
|
||
| @Flag(help: "Use plain text http to authenticate") var http: Bool = false | ||
| @Flag(help: "(DEPRECATED) Use plain-text HTTP. Credentials will be transmitted in cleartext; this flag will be removed in a future release.") | ||
| var http: Bool = false |
Contributor
There was a problem hiding this comment.
Since this is just a tool for lightweight testing, I say we just remove this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.