ci: add clang-tidy github action

[ploxiln]

using the foundationdb/build:rockylinux9-latest container image

---

I'll shortly push up a change that should fail the clang-tidy check, to test whether this action is fully working ...

[tclinkenbeard-oai]

The rules can be applied to generated files as well, but I'm not sure if that's clean currently

[ploxiln]

Yes, this skips the input actor files (not compatible), and the output generated cpp files (which we may want some clang-tidy rules to check) ... but hopefully as your work lands, they will all be gone soon enough :)

[gxglass]

It seems fine either way. Agent wants to know if it's supposed to be advisory only for now: If the intent is to enforce the .clang-tidy checks on PRs, add --warnings-as-errors='*' (or a curated subset) to the invocation. If the intent is advisory-only for now, that's fine — but it's worth a comment in the file saying so, because the job name and PR trigger strongly imply enforcement

[ploxiln]

If the intent is advisory-only for now, that's fine — but it's worth a comment in the file saying so

Comment added to the workflow file, hopefully that helps if someone goes into adjust things later.

Thanks, both, for the reviews 🙏