Skip to content

Break ExpressibleByArgument default ambiguity #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natecook1000 merged 1 commit into from
Dec 15, 2025
+24 −0
Merged

Break ExpressibleByArgument default ambiguity #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Sources/ArgumentParser/Parsable Types/ExpressibleByArgument.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,17 @@ extension LosslessStringConvertible where Self: ExpressibleByArgument {
}
}

extension LosslessStringConvertible
where
Self: ExpressibleByArgument & RawRepresentable,
RawValue: ExpressibleByArgument
{
// Ambiguity breaker
public init?(argument: String) {
self.init(argument)
}
}

extension Int: ExpressibleByArgument {}
extension Int8: ExpressibleByArgument {}
extension Int16: ExpressibleByArgument {}
Expand Down
13 changes: 13 additions & 0 deletions Tests/ArgumentParserEndToEndTests/RawRepresentableEndToEndTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,16 @@ extension RawRepresentableEndToEndTests {
XCTAssertThrowsError(try Bar.parse(["--identifier", "123.456"]))
}
}

struct LogLevel: RawRepresentable, CustomStringConvertible {
var rawValue: String
var description: String { rawValue }
}

extension LogLevel: LosslessStringConvertible {
init(_ description: String) {
self.rawValue = description
}
}

extension LogLevel: ExpressibleByArgument {}