Contest2

[Y-Nak]

This PR is a successor to #276.

The main changes from #276 are

1. Contract test is now integrated intocabal
2. By default, tests fail if testrunner/evmone are missing (skip only with SOLCORE_CONTRACT_TESTS_ALLOW_SKIP=1)
3. intx and blst are pinned in nix/evmone-pins.nix and checked against evmone’s own CMake pins at build time

[rodrigogribeiro]

LGTM.

[mbenke]

After checking out to a fresh dir and running cabal test I get an error

CMake Error at CMakeLists.txt:13 (find_package):
  By not providing "Findnlohmann_json.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "nlohmann_json", but CMake did not find one.

  Could not find a package configuration file provided by "nlohmann_json"
  with any of the following names:

    nlohmann_jsonConfig.cmake
    nlohmann_json-config.cmake

  Add the installation prefix of "nlohmann_json" to CMAKE_PREFIX_PATH or set
  "nlohmann_json_DIR" to a directory containing one of the above files.  If
  "nlohmann_json" provides a separate development package or SDK, be sure it
  has been installed.


-- Configuring incomplete, errors occurred!

Then running git submodule update

$ git submodule update --init --depth 1 deps/nlohmann_json
remote: Total 0 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
fatal: remote error: upload-pack: not our ref a0e9fb1e638cfbb5b8b556b7c51eaa81977bad48
fatal: Fetched in submodule path 'deps/nlohmann_json', but it did not contain a0e9fb1e638cfbb5b8b556b7c51eaa81977bad48. Direct fetching of that commit failed.

This error seems to be silenced in the script:

    if [[ ! -f "$root_dir/deps/nlohmann_json/CMakeLists.txt" ]] && command -v git >/dev/null 2>&1; then
        git -C "$root_dir" submodule update --init --depth 1 deps/nlohmann_json >/dev/null 2>&1 || true
    fi

Running nix develop then cabal build and cabal test separately also does not help:

[mbenke]

Sorry, it partly my fault - it seems that the directory wasn't as clean as I thought - git worktree copied tainted submodules there. But the point about silencing the error still stands:

    if [[ ! -f "$root_dir/deps/nlohmann_json/CMakeLists.txt" ]] && command -v git >/dev/null 2>&1; then
        git -C "$root_dir" submodule update --init --depth 1 deps/nlohmann_json >/dev/null 2>&1 || true
    fi

causes errors to be silently ignored here and explode in cmake.

[Y-Nak]

I'll look into this problem this weekend(I can't work Wednesday and Thursday this week).

[mbenke]

Well done 👌